Feat/fun 1740/update elastic lib #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tikhanovichA
requested review from
gabrielfs7,
bartlomiejmarszal,
pnal and
Karol-Stelmaczonek
gabrielfs7
reviewed
Jun 25, 2024
model/SearchEngine/Driver/Elasticsearch/ElasticSearchClientFactory.php
Outdated
Show resolved
Hide resolved
gabrielfs7
reviewed
Jun 25, 2024
gabrielfs7
reviewed
Jun 25, 2024
gabrielfs7
reviewed
Jun 25, 2024
model/SearchEngine/Driver/Elasticsearch/ElasticSearchConfig.php
Outdated
Show resolved
Hide resolved
gabrielfs7
reviewed
Jun 25, 2024
gabrielfs7
reviewed
Jun 25, 2024
model/SearchEngine/Driver/Elasticsearch/ElasticSearchConfig.php
Outdated
Show resolved
Hide resolved
gabrielfs7
reviewed
Jun 25, 2024
model/SearchEngine/Driver/Elasticsearch/ElasticSearchConfig.php
Outdated
Show resolved
Hide resolved
gabrielfs7
reviewed
Jun 25, 2024
model/SearchEngine/Driver/Elasticsearch/ElasticSearchConfig.php
Outdated
Show resolved
Hide resolved
gabrielfs7
reviewed
Jun 25, 2024
model/SearchEngine/Driver/Elasticsearch/ElasticSearchConfig.php
Outdated
Show resolved
Hide resolved
Karol-Stelmaczonek
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
gabrielfs7
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
LGTM, thanks!
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
gabrielfs7
reviewed
Jun 25, 2024
|
@gabrielfs7 @Karol-Stelmaczonek Thanks for the review. |
pnal
approved these changes
Jun 25, 2024
tikhanovichA
force-pushed
the
feat/FUN-1740/update-elastic-lib
branch
from
1de8f5f to
4f2bcc9
Compare
ar0oat
reviewed
Jul 24, 2024
Signed-off-by: Aleksej Tikhanovich <tihanovich.a@gmail.com>
Version
There are 0 BREAKING CHANGE, 6 features, 5 fixes |
ar0oat
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of Elasticsearch 8
Depends on oat-sa/tao-core#4058 oat-sa/lib-tao-elasticsearch#77