Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add option for faster resource type item or test determination #125

Merged

Conversation

pnal
Copy link
Contributor

@pnal pnal commented Sep 11, 2024

This PR aims to avoid recursive class structure querying to identify resource type in the most cases.

Some background:
For translations we import a huge amount of test packages that triggers indexation and as well as we use nested and huge classes structure. It was found that at some point we have a huge frequently repeated query which stresses DB:
image

@pnal pnal requested review from gabrielfs7 and hectoras September 11, 2024 13:42
Copy link

Version

Target Version 1.17.2
Last version 1.17.1

There are 0 BREAKING CHANGE, 0 feature, 2 fixes

@tikhanovichA tikhanovichA self-requested a review September 17, 2024 12:10
Copy link
Contributor

@tikhanovichA tikhanovichA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, thanks

@pnal pnal merged commit 9b9313e into develop Sep 30, 2024
4 checks passed
@pnal pnal deleted the feat/ADF-1761/avoid-slow-query-to-determine-resource-type branch September 30, 2024 09:05
@gabrielfs7 gabrielfs7 mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants