Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Use delta of Root class permissions #231

Merged
merged 2 commits into from
Jul 6, 2023
Merged

[Fix] Use delta of Root class permissions #231

merged 2 commits into from
Jul 6, 2023

Conversation

shpran
Copy link
Contributor

@shpran shpran commented Jul 6, 2023 •
edited by jira bot
Loading

ADF-1541

Changelog

  • Instead of calculating permissions delta for every class, we will use permissions delta of the root class
  • Added new task parameter to provide permissions delta
  • Added new command parameter to provide permissions delta

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Version

Target Version 7.10.3
Last version 7.10.2

There are 0 BREAKING CHANGE, 0 feature, 1 fix

@hectoras
Copy link
Contributor

hectoras commented Jul 6, 2023 •
edited
Loading

ChangePermissionsCommandTest is now failing, could you please take a look at it? We now need to pass an additional parameter to ChangePermissionsCommand, probably passing an empty array would suffice to fix the current tests 🙂

@shpran
Copy link
Contributor Author

shpran commented Jul 6, 2023

ChangePermissionsCommandTest is now failing, could you please take a look at? We now need to pass an additional parameter to ChangePermissionsCommand, probably passing an empty array would suffice to fix the current tests 🙂

Already fixed, thanks 🙂

@shpran shpran requested a review from gabrielfs7 July 6, 2023 07:46
hectoras
hectoras approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@hectoras hectoras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • New code is covered by tests (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • Acceptance criteria are respected
  • Kitchen links are not exposed in the description
  • No unnecessary dependencies are installed
  • Target branch is correct
  • Change log provided

gabrielfs7
gabrielfs7 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job @shpran 🎉

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@shpran shpran merged commit 2bfb611 into develop Jul 6, 2023
@shpran shpran deleted the fix/adf-1541/use-root-class-delta branch July 6, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielfs7 gabrielfs7 gabrielfs7 approved these changes

@hectoras hectoras hectoras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shpran @hectoras @gabrielfs7