fix: audio pci controls fliped for RTL #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marpesia
requested changes
Mar 24, 2022
views/js/pciCreator/dev/audioRecordingInteraction/runtime/scss/audioRecordingInteraction.scss
Show resolved
Hide resolved
| @include rtl { | ||
| margin: 10px 0 10px 10px; | ||
| display: flex; |
There was a problem hiding this comment.
Did you try to move the display: flex rule to the .audiorec-control parent?
This change should avoid the size jump when we switch the direction.
There was a problem hiding this comment.
parent already has display: flex, applying it here acts over the text and the svg image, if removed those two don't flip... but you're right there is a small jump in size, need to look into that...
bziondik
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
Version
There are 0 BREAKING CHANGE, 0 feature, 4 fixes |
marpesia
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
LGTM
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
bziondik
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue: https://oat-sa.atlassian.net/browse/AUT-2009
Fix : Audio PCI controls should be on the left even in RTL
SETPS to test:
• Checkout to branch: fix/AUT-2009/audio-pci-flipped
• Run taoUpdate.php
• Create an item and add an audio interaction
• Set the language to a RTL one (e.g. Arab)
ACTUAL RESULT:
Audio pci controls show on the right side
EXPECTED RESULT:
The audio controls show on the Left, the same way as in LTR