fix: correct bg color of pci pop up #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marpesia
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Verify that the PCI popup is still blue and the others are not.
To reproduce the PCI popup, make an assessment and finish without recording anything. Go to the Result page, view the test and try to reproduce the PCI.
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
bziondik
suggested changes
Apr 27, 2022
Version
There are 0 BREAKING CHANGE, 0 feature, 2 fixes |
bziondik
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
Silvia-loza
deleted the
fix/TR-3799/pop-up-window-wrong-color-blue-audio-pci
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue: https://oat-sa.atlassian.net/browse/TR-3799
Fix : All pop up windows in Audio pci interaction show blue
SETPS to test:
• Checkout to branch: fix/TR-3799/pop-up-window-wrong-color-blue-audio-pci
•Run taoUpdate
•Create an item and add an audioRecodingInteraction
•Try to leave the widow without saving.
ACTUAL RESULT:
Pop up ha blue background, this can be observed in all pop ups when this interaction is present
EXPECTED RESULT:
The background should be white as standard
Also check that the solution for TR-3354 is not affected by this solution