Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/TR-4494/add new symbols in Math PCI #319

Merged
merged 6 commits into from
Sep 7, 2022

Conversation

bziondik
Copy link
Contributor

@bziondik bziondik commented Sep 6, 2022

Related to: https://oat-sa.atlassian.net/browse/TR-4494
Based on:

The following symbols are added in the Math Entry PCI virtual keyboard (follow links for visual representations):

To use source files for PCI:

  1. run script php index.php '\oat\taoQtiItem\scripts\initEventCreatorLoad'
  2. create file config/taoQtiItem/debug_portable_element.conf.php with
<?php
return [
'mathEntryInteraction' => 'qtiItemPci/views/js/pciCreator/ims/mathEntryInteraction/',
];
?>

image
image

Copy link
Contributor

@marpesia marpesia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic
  • Changelog is updated according to changes (if applicable)
  • Documentation is updated according to changes (if applicable)

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Version

Target Version 8.3.0
Last version 8.2.2

There are 0 BREAKING CHANGE, 5 features, 0 fix

Copy link
Contributor

@Silvia-loza Silvia-loza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • Pull request's target is not master
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@bziondik bziondik merged commit f6d1f93 into develop Sep 7, 2022
@bziondik bziondik deleted the feat/TR-4494/add-symbols-math-pci branch September 7, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants