Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/aut 2551/fix response saving auth math entry pci #329

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions migrations/Version202209151238261465_qtiItemPci.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<?php

declare(strict_types=1);

namespace oat\qtiItemPci\migrations;

use Doctrine\DBAL\Schema\Schema;
use oat\tao\scripts\tools\migrations\AbstractMigration;
use Doctrine\Migrations\Exception\IrreversibleMigration;
use oat\qtiItemPci\scripts\install\RegisterPciMathEntry;

/**
* Auto-generated Migration: Please modify to your needs!
*/
final class Version202209151238261465_qtiItemPci extends AbstractMigration
{

public function getDescription(): string
{
return 'Register new version of Math Entry PCI fixing the result saving on authoring';
}

public function up(Schema $schema): void
{
$this->addReport(
$this->propagate(
new RegisterPciMathEntry()
)(
['2.0.3']
)
);

}

public function down(Schema $schema): void
{
throw new IrreversibleMigration(
'In order to undo this migration, please revert the client-side changes and run ' . RegisterPciMathEntry::class
);

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -303,10 +303,9 @@ define([
}

MathEntryInteractionStateResponse.prototype.inGapMode = function inGapMode() {
var self = this,
interaction = self.widget.element;

return interaction.prop('useGapExpression');
var interaction = this.widget.element;
var useGapExpression = interaction.prop('useGapExpression');
return useGapExpression && useGapExpression !== 'false' || false;
}

return MathEntryInteractionStateResponse;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"label": "Math entry",
"short": "Math entry",
"description": "Allow test taker to type math formulas",
"version": "2.0.2",
"version": "2.0.3",
"author": "Christophe Noël",
"email": "christophe@taotesting.com",
"tags": [
Expand Down
1,275 changes: 1,274 additions & 1 deletion views/js/pciCreator/ims/mathEntryInteraction/imsPciCreator.min.js

Large diffs are not rendered by default.

Large diffs are not rendered by default.

15,600 changes: 15,599 additions & 1 deletion views/js/pciCreator/ims/mathEntryInteraction/runtime/mathEntryInteraction.min.js

Large diffs are not rendered by default.

Large diffs are not rendered by default.