Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/aut 3982 custom label not showing #2628

Merged
merged 10 commits into from
Nov 22, 2024

Conversation

bartlomiejmarszal
Copy link
Contributor

Ignore properties without range
Default properties can be applied both for tests and items

Copy link

github-actions bot commented Nov 21, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
287 287 0 0

@bartlomiejmarszal bartlomiejmarszal marked this pull request as ready for review November 22, 2024 08:28
Copy link
Contributor

@Karol-Stelmaczonek Karol-Stelmaczonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

model/qti/metadata/ontology/MappedMetadataInjector.php Outdated Show resolved Hide resolved
Copy link

Version

Target Version 30.22.5
Last version 30.22.4

There are 0 BREAKING CHANGE, 0 feature, 10 fixes

@bartlomiejmarszal bartlomiejmarszal merged commit 5faf31d into develop Nov 22, 2024
5 checks passed
@bartlomiejmarszal bartlomiejmarszal deleted the fix/AUT-3982-custom-label-not-showing branch November 22, 2024 09:42
bartlomiejmarszal added a commit that referenced this pull request Nov 22, 2024
fix: metadata import export bug

* fix: match all properties for item & test

* fix: make sure range exist for property. If not do not import value

* fix: include existing property value removal only if resource contain property value

* fix: finish comment

* fix: Readonly Widget property ommited, secure missing range properties

* fix: remove exception

* fix: testInject

* fix: fix line length

* fix: phpcbf fix

* fix: make sure getWidget not return null

---------

Co-authored-by: Karol Stelmaczonek <karol.stelmaczonek@taotesting.com>
bartlomiejmarszal added a commit that referenced this pull request Nov 22, 2024
fix: metadata import export bug

* fix: match all properties for item & test

* fix: make sure range exist for property. If not do not import value

* fix: include existing property value removal only if resource contain property value

* fix: finish comment

* fix: Readonly Widget property ommited, secure missing range properties

* fix: remove exception

* fix: testInject

* fix: fix line length

* fix: phpcbf fix

* fix: make sure getWidget not return null

---------

Co-authored-by: Karol Stelmaczonek <karol.stelmaczonek@taotesting.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants