Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new term language #473

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: add new term language #473

wants to merge 1 commit into from

Conversation

marpesia
Copy link

@marpesia marpesia commented Jun 5, 2024 •
edited
Loading

Related to: AUT-3624

Description:
Add new terms on a new locale language on the new SolarUi theme enabled
Please check companion PRs on the ticket

Changes:

  • Check Google Sheet with new terms

How to check:

php  tao/scripts/taoTranslate.php -v -a=compile -e=taoTest -l=en-US-S

Necessary PRs

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Version

Target Version 16.2.0
Last version 16.1.4

There are 0 BREAKING CHANGE, 1 feature, 0 fix

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
0 0 0 0

@marpesia marpesia marked this pull request as ready for review June 6, 2024 14:26
@marpesia marpesia requested review from jsconan, pribi and SultanSagi June 6, 2024 14:26
jsconan
jsconan approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I did not verify every translation though.

Worth noting: the command mentioned in the description is wrong, the correct one is

php tao/scripts/taoTranslate.php -v -a=compile -e=taoTests -l=en-US-S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsconan jsconan jsconan approved these changes

@pribi pribi Awaiting requested review from pribi

@SultanSagi SultanSagi Awaiting requested review from SultanSagi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marpesia @jsconan