fix/ADF-1827/sync-translations-on-authoring #490
Conversation
Front-end summary Node 18
|
| @@ -251,6 +252,7 @@ public function authoring() | |||
| ); | |||
| } | |||
| if ($this->getRequestParameter('originResourceUri') !== null) { | |||
| $this->getTranslationSyncService()->syncById($this->getRequestParameter('originResourceUri')); | |||
There was a problem hiding this comment.
@shaveko the FE already calls and endpoint translation/sync to call the syncByRequest. I am not sure also asking the BE to do the same is a good idea 🤔
There was a problem hiding this comment.
please check comment to the ticket
There was a problem hiding this comment.
Now yes, if we remove the FE part of the code, it makes sense to do it on the BE side. When I checked the PRs, there was only the BE part introduced, so the call would be redundant and this sync process is quite expensive.
There was a problem hiding this comment.
LGTM, Good job!
Code review only
- [] New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- [] Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
There was a problem hiding this comment.
Code looks good, and it runs fine.
One note, though, when I add an item to the main test, it does not show up in the translated test.
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
Version
There are 0 BREAKING CHANGE, 0 feature, 2 fixes |
related to https://oat-sa.atlassian.net/browse/ADF-1827
Description
Once
originResourceUriis provided to the authoring call, sync the translationsHow to test
checkout related tao branches
Steps to reproduce / check if issue is fixed:
label should exist for the item