Feat/aut 3590/fix form checkbox #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomiejmarszal
requested review from
tikhanovichA,
pnal and
Karol-Stelmaczonek
Version
There are 0 BREAKING CHANGE, 0 feature, 2 fixes |
Front-end summary Node 18
|
tikhanovichA
approved these changes
May 16, 2024
Karol-Stelmaczonek
approved these changes
May 16, 2024
wazelin
reviewed
May 16, 2024
| $testResource | ||
| ); | ||
| //todo: fix taoSetup to be aware of containers. This is only workaround. | ||
| if ($this->getServiceManager()->getContainer()->has(MappedMetadataInjector::class)) { |
There was a problem hiding this comment.
How do you plan injecting the properties on the fresh installation of TAO 3.x?
There was a problem hiding this comment.
We need to fix taoSetup so it will be able to use Service Containers. At the initial step i do not see a reason to import metadata.
pnal
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix label for import checkbox on test import form.
taoSetup when importing test will not use container if not exist. This is workaround.