-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration/rfe 1247 m3/solar design feature hiding #2482
Integration/rfe 1247 m3/solar design feature hiding #2482
Conversation
…UT-3623/hide-features-in-solar-design
Co-authored-by: Gabriel Felipe Soares <gabrielfs7@gmail.com> Signed-off-by: Saba <23014889+Nevermind23@users.noreply.github.com>
…olar-design feat/aut-3623/hide-features-in-solar-design
…ode-switch Feat/aut 3625/content creation mode switch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Approving the BE part here. Thanks!
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
- Commits are following conventional commits
- Commits messages are meaningful
…sign-feature-hiding' into integration/RFE-1247-M3/solar-design-feature-hiding
Signed-off-by: Saba <23014889+Nevermind23@users.noreply.github.com>
Version
There are 0 BREAKING CHANGE, 8 features, 4 fixes |
Front-end summary Node 18
|
related to
###Description
This PR addresses requirement 3.h from the ticket to hide various test props if solar design is activated.
This is an integration branch from FE and BE changes :
FE: #2475
BE: #2481
How to test
To test locally the dependent FE/BE branches should be specified in
composer.json
Deployed to kitchen env, so functionally can be validated there: http://test-rfe-1147-facelift.playground.kitchen.it.taocloud.org:49381/
List of the related PRs (this PR doesn't depend on them, but can be reviewed together):
How to test
ℹ️ Backend part is not available yet. To activate feature hiding you need to update the configuration in
tao/config/tao/client_lib_config_registry.conf.php
, then feature hiding can be validated