Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration/rfe 1247 m3/solar design feature hiding #2482

Merged

Conversation

shaveko
Copy link
Contributor

@shaveko shaveko commented Jun 14, 2024

related to

⚠️ Update extension version to the release ones before merging

###Description

This PR addresses requirement 3.h from the ticket to hide various test props if solar design is activated.

This is an integration branch from FE and BE changes :

FE: #2475
BE: #2481

How to test

To test locally the dependent FE/BE branches should be specified in composer.json

Deployed to kitchen env, so functionally can be validated there: http://test-rfe-1147-facelift.playground.kitchen.it.taocloud.org:49381/

List of the related PRs (this PR doesn't depend on them, but can be reviewed together):

How to test

ℹ️ Backend part is not available yet. To activate feature hiding you need to update the configuration in tao/config/tao/client_lib_config_registry.conf.php, then feature hiding can be validated

        'services/features' => array(
            'visibility' => array(
                'taoQtiItem/creator/item/property/identifier' => 'hide',
                'taoQtiItem/creator/interaction/response/property/identifier' => 'hide',
                'taoQtiItem/creator/interaction/response/responseProcessing/custom' => 'hide',
                'taoQtiItem/creator/interaction/choice/property/orientation' => 'hide',
                'taoQtiItem/creator/interaction/extendedText/property/constraints' => 'hide',
                'taoQtiItem/creator/static/text/scrolling' => 'hide',
                'taoQtiItem/creator/interaction/textEntry/property/base' => 'hide',
                'taoQtiItem/creator/interaction/textEntry/property/constraints' => 'hide',
                'taoQtiItem/creator/interaction/textEntry/property/recommendations' => 'hide',
                'taoQtiItem/creator/interaction/pci/liquidsInteraction' => 'hide',
                'taoDeliverConnect/publish/singleTenant' => 'hide',
                'taoQtiTest/creator/test/property/identifier' => 'hide',
                'taoQtiTest/creator/test/property/lateSubmission' => 'hide',
                'taoQtiTest/creator/test/property/scoring/custom' => 'hide',
                'taoQtiTest/creator/test/property/scoring/weight' => 'hide',
                'taoQtiTest/creator/test/property/outcomeDeclarations' => 'hide',
                'taoQtiTest/creator/testPart/property/identifier' => 'hide',
                'taoQtiTest/creator/testPart/property/lateSubmission' => 'hide',
                'taoQtiTest/creator/testPart/property/itemSessionControl' => 'hide',
                'taoQtiTest/creator/testPart/category/presetGroup/warning' => 'hide',
                'taoQtiTest/creator/section/property/identifier' => 'hide',
                'taoQtiTest/creator/section/property/lateSubmission' => 'hide',
                'taoQtiTest/creator/section/property/visible' => 'hide',
                'taoQtiTest/creator/section/property/keepTogether' => 'hide',
                'taoQtiTest/creator/section/property/itemSessionControl/validateResponses' => 'hide',
                'taoQtiTest/creator/section/property/itemSessionControl/showFeedback' => 'hide',
                'taoQtiTest/creator/section/property/rubricBlocks/class' => 'hide',
                'taoQtiTest/creator/itemRef/property/identifier' => 'hide',
                'taoQtiTest/creator/itemRef/property/reference' => 'hide',
                'taoQtiTest/creator/itemRef/property/lateSubmission' => 'hide',
                'taoQtiTest/creator/itemRef/category/presetGroup/navigation' => 'hide',
                'taoQtiTest/creator/itemRef/property/itemSessionControl/showFeedback' => 'hide',
                'taoQtiTest/creator/itemRef/property/itemSessionControl/validateResponses' => 'hide',
                'taoQtiTest/creator/itemRef/property/weights' => 'hide',
                'taoDeliveryRdf/deliveryMgmt/resourceIdentifier' => 'hide',
                'taoDeliveryRdf/deliveryMgmt/maxExecutions' => 'hide',
                'taoDeliveryRdf/deliveryMgmt/startDate' => 'hide',
                'taoDeliveryRdf/deliveryMgmt/endDate' => 'hide',
                'taoDeliveryRdf/deliveryMgmt/displayOrder' => 'hide',
                'taoDeliveryRdf/deliveryMgmt/access' => 'hide',
                'taoDeliveryRdf/deliveryMgmt/proctoringSettings' => 'hide',
                'taoDeliveryRdf/deliveryMgmt/publicationId' => 'hide',
                'taoDeliveryRdf/deliveryMgmt/assessmentProjectId' => 'hide'
            )
        ),

@shaveko shaveko requested a review from jsconan June 14, 2024 11:52
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Approving the BE part here. Thanks!

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master

Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful

shaveko and others added 3 commits June 20, 2024 18:43
Signed-off-by: Saba <23014889+Nevermind23@users.noreply.github.com>
Copy link

Version

Target Version 48.7.0
Last version 48.6.1

There are 0 BREAKING CHANGE, 8 features, 4 fixes

Copy link

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
708 708 0 0

@Nevermind23 Nevermind23 merged commit 3b5d5cb into develop Jun 24, 2024
5 checks passed
@Nevermind23 Nevermind23 deleted the integration/RFE-1247-M3/solar-design-feature-hiding branch June 24, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants