TAO-8697 - Replace Calls of singleton method by ServiceManager calls #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-sebire
requested changes
Jul 17, 2019
| @@ -30,7 +30,8 @@ | |||
| use oat\taoTestTaker\models\TestTakerService; | |||
| use core_kernel_classes_Resource; | |||
| use core_kernel_classes_Class; | |||
|
|
|||
| use oat\generis\test\TestCase; | |||
| use oat\taoLti\models\classes\user\UserService as UserService; | |||
There was a problem hiding this comment.
You don't need the alias here, since UserService is already the base name of the class.
test/integration/TestTakerTest.php
Outdated
| @@ -30,7 +30,8 @@ | |||
| use oat\taoTestTaker\models\TestTakerService; | |||
| use core_kernel_classes_Resource; | |||
| use core_kernel_classes_Class; | |||
|
|
|||
| use oat\generis\test\TestCase; | |||
There was a problem hiding this comment.
Is oat\generis\test\TestCase used in the class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://oat-sa.atlassian.net/browse/TAO-8697
Replace Calls of singleton method by ServiceManager calls
Classes which are extending the OntologyClass ConfigurableService, are retrieved by using the ServiceManager::get() method instead of calling the deprecated singleton method.