Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enforce default value for testtaker import #239

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

siwane
Copy link
Collaborator

@siwane siwane commented Jan 17, 2024

Description
The goal of this PR is to enforce the default language to be the same as UI language

Ticket
https://oat-sa.atlassian.net/browse/OATSD-2979

@siwane siwane requested review from tatsianazh and shpran January 17, 2024 13:52
Copy link

Version

Target Version 8.12.0
Last version 8.11.2

There are 0 BREAKING CHANGE, 1 feature, 0 fix

@codecov-commenter
Copy link

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (44530b3) 1.57% compared to head (ec1731f) 1.55%.

Files Patch % Lines
models/CsvImporter.php 0.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             develop    #239      +/-   ##
============================================
- Coverage       1.57%   1.55%   -0.03%     
- Complexity       141     142       +1     
============================================
  Files             21      21              
  Lines            570     580      +10     
============================================
  Hits               9       9              
- Misses           561     571      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siwane siwane merged commit 13dfebe into develop Jan 17, 2024
4 checks passed
@siwane siwane deleted the fix/OATSD-2979/testtaker-import-def-lang branch January 17, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants