REL-1198: List value URI definition should work with neo4j RDF storage. #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbyndych
force-pushed
the
feat/REL-1198/list-neo4j
branch
from
1820fd2 to
9cbb8a7
Compare
vbyndych
force-pushed
the
feat/REL-1198/list-neo4j
branch
from
93296c4 to
eb99b90
Compare
yaraslau-kavaliou
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Great job!
Tested locally with sql and neo4j databases and updating uri functionality for lists works without issues.
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not master
- Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
| $result = $this->fetchTripleList( | ||
| parent::searchTriples($Builder, $propertyUri, $isDistinct) | ||
| ); | ||
| return new $this->resultSetClassName($result, count($result)); |
There was a problem hiding this comment.
nitpick: Adding empty line before return statement here and in other methods looks like a good idea
| /** | ||
| * Changes class URI for all its properties and linked objects. | ||
| * | ||
| * @param core_kernel_classes_Class $resource |
There was a problem hiding this comment.
Not important at all, but just thought if we have type hinting in method declaration we don't need to add them to phpdoc. Wdyt?
There was a problem hiding this comment.
I totally agree. Will fix.
Base automatically changed from
feat/REL-1197/rdf-import-export-neo4j
to
poc/REL-1106/rdf-in-neo4j
October 20, 2023 09:03
…used duplicate of the item.
…e in the child operations.
…tion path was not built properly.
augustas
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Looking good and working good for me
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
Version
There are 0 BREAKING CHANGE, 1 feature, 7 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
List value URIs can be modified via user interface. Yet implementation is modifying SQL statements table directly, and would not work with neo4j RDF storage.
Changelog
Dependencies
oat-sa/lib-generis-search#32