fix: Refactor neo4j queries #1081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
yaraslau-kavaliou
force-pushed
the
feat/REL-1251/refactor-neo4j-queries
branch
2 times, most recently
from
12392ed to
d3fc50a
Compare
yaraslau-kavaliou
force-pushed
the
feat/REL-1251/refactor-neo4j-queries
branch
from
d3fc50a to
3541639
Compare
yaraslau-kavaliou
force-pushed
the
feat/REL-1251/refactor-neo4j-queries
branch
from
5b8f4f5 to
999703b
Compare
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
augustas
reviewed
Dec 15, 2023
Comment on lines
+86
to
+88
| $subClasses = $class->getParentClasses(); | ||
|
|
||
| $this->assertCount(0, $subClasses); |
There was a problem hiding this comment.
Suggested change
| $subClasses = $class->getParentClasses(); | |
| $this->assertCount(0, $subClasses); | |
| $parentClasses = $class->getParentClasses(); | |
| $this->assertCount(0, $parentClasses); |
| $resource->removePropertyValues($property); | ||
| $result = $this->object->getPropertiesValues($resource, [$property]); | ||
|
|
||
| $this->assertFalse(in_array(new core_kernel_classes_Literal('prop1'), $result[$property->getUri()])); |
There was a problem hiding this comment.
Maybe should instead check if result array is empty?
| $resource->removePropertyValues($property, ['pattern' => 'prop1']); | ||
| $propertiesValues = $this->object->getPropertiesValues($resource, [$property]); | ||
|
|
||
| $this->assertFalse(in_array(new core_kernel_classes_Literal('prop1'), $propertiesValues[$property->getUri()])); |
There was a problem hiding this comment.
I believe in_array($object, [$some, $other, $objects, $even, $with, $same, $conents]) will always return false. Unless strict parameter is passed to in_array, but then it checks for exact same object instance, and it wouldn't work here. So I think all these test cases doing assertFalse(in_array(...)) actually don't check anything 🤔
| $this->assertFalse(in_array(new core_kernel_classes_Literal('prop1'), $propertiesValues[$property->getUri()])); | ||
| } | ||
|
|
||
| public function testRemovePropertyValueWithPatternLikeTrueUsingTwoPatternsAndBothOfThemHaveToBeMeet() |
There was a problem hiding this comment.
Suggested change
| public function testRemovePropertyValueWithPatternLikeTrueUsingTwoPatternsAndBothOfThemHaveToBeMeet() | |
| public function testRemovePropertyValueWithPatternLikeTrueUsingTwoPatternsAndBothOfThemHaveToBeMet() |
| $this->assertFalse(in_array(new core_kernel_classes_Literal('prop1'), $result[$property->getUri()])); | ||
| } | ||
|
|
||
| public function testRemovePropertyValueWithPatternLikeTrueUsingThreePatternsTwoOfThemHaveToBeMeetOtherOptional() |
There was a problem hiding this comment.
Suggested change
| public function testRemovePropertyValueWithPatternLikeTrueUsingThreePatternsTwoOfThemHaveToBeMeetOtherOptional() | |
| public function testRemovePropertyValueWithPatternLikeTrueUsingThreePatternsTwoOfThemHaveToBeMetOtherOptional() |
| $this->assertFalse(in_array(new core_kernel_classes_Literal('prop1'), $propertiesValues[$property->getUri()])); | ||
| } | ||
|
|
||
| public function testRemovePropertyValueWithPatternLikeFalseAndTwoPatternsWhichOnlyOneHasToBeMeet() |
There was a problem hiding this comment.
Suggested change
| public function testRemovePropertyValueWithPatternLikeFalseAndTwoPatternsWhichOnlyOneHasToBeMeet() | |
| public function testRemovePropertyValueWithPatternLikeFalseAndTwoPatternsWhichOnlyOneHasToBeMet() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket - https://oat-sa.atlassian.net/browse/REL-1251
Reworking of PR - #1064