Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADF-1611: TAO Studio - Neo4j: 500 'Something unexpected happened' error when using 'QA ACL' login #1087

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

vbyndych
Copy link
Contributor

@vbyndych vbyndych commented Nov 15, 2023

Goal

Fix problem described in https://oat-sa.atlassian.net/browse/ADF-1611

Changelog

  • fix: updated function to avoid dupliucates of translations in case data nad default language are the same.
  • refactor: rewrite test to decrease complexity.

How to test / use

  1. Open log in page
  2. Use Login “QA ACL“ and any password (may work with “1234q“ only)
  3. Click Log in

Before:
image-20231109-115814

After:
Screenshot_2023-11-15_15-37-09

Copy link

Version

Target Version 15.32.1
Last version 15.32.0

There are 0 BREAKING CHANGE, 0 feature, 1 fix

Copy link
Contributor

@yaraslau-kavaliou yaraslau-kavaliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests
  • Tests are running successfully on my local machine
  • New code is respecting code style rules
  • New code is respecting best practices
  • Feature is working correctly on my local machine
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

Looks good and works locally for me

@vbyndych vbyndych merged commit 50cf857 into develop Nov 21, 2023
5 of 6 checks passed
@vbyndych vbyndych deleted the fix/ADF-1611/non-unique-values branch November 21, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants