Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REL-1315: NEO4J Inability to add Assets to Items as far as they are not presented in the stimuli bank #1102

Merged
merged 1 commit into from
Jan 16, 2024
Merged

REL-1315: NEO4J Inability to add Assets to Items as far as they are not presented in the stimuli bank #1102

merged 1 commit into from
Jan 16, 2024

Conversation

vbyndych
Copy link
Contributor

@vbyndych vbyndych commented Jan 10, 2024 •
edited
Loading

Goal

Fixed the following problem: "When the user tries to add any stimulus via CKEditor, the media bank presented empty, no matter if there are assets created"

Changelog

  • fix: escaped special characters which could be interpreted incorrectly within regex.

How to test / use

  1. Go to the Items tab
  2. Create new item
  3. Add any interaction to the field
  4. Focus on the prompt/choice or any area available to be modified via CKE
  5. Click “Insert Shared Stimulus“

After the fix:
Screenshot_2024-01-10_18-46-40

@github-actions GitHub Actions
Copy link

Version

Target Version 15.35.3
Last version 15.35.2

There are 0 BREAKING CHANGE, 0 feature, 1 fix

mike-ionut-mihai-sandu-tao
mike-ionut-mihai-sandu-tao approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
i did not test so let's make sure that we have a test in place for this

@vbyndych vbyndych merged commit 49282ba into develop Jan 16, 2024
5 of 6 checks passed
@vbyndych vbyndych deleted the fix/REL-1315-shared-stimulus branch January 16, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccar mccar mccar approved these changes

@augustas augustas augustas approved these changes

@mike-ionut-mihai-sandu-tao mike-ionut-mihai-sandu-tao mike-ionut-mihai-sandu-tao approved these changes

@yaraslau-kavaliou yaraslau-kavaliou Awaiting requested review from yaraslau-kavaliou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vbyndych @mccar @augustas @mike-ionut-mihai-sandu-tao