Fix/ttl mode on windows #535
Conversation
|
Code Climate has analyzed commit d4d7e26 and detected 0 issues on this pull request. View more on Code Climate. |
| if ($entry != false && $this->isTtlMode()) { | ||
| $entry = (is_null($entry[static::ENTRY_EXPIRATION]) || $entry[static::ENTRY_EXPIRATION] > $this->getTime()) | ||
|
|
||
| if ($entry !== false && $this->isTtlMode()) { |
There was a problem hiding this comment.
| if ($entry !== false && $this->isTtlMode()) { | |
| if ($entry !== false && $this->isTtlMode()) { |
@jbout Please, confirm that I can change this behavior: before it worked like this: when file has return null - driver return null as a result, but now in such situation it returns 'false'
There was a problem hiding this comment.
if ttlMode is true, no file should ever return "null", it should still always return an array with the expiry and the value
|
@jbout I've added unit tests, check this, please |
|
Can you please link the ticket, or describe the issue it is fixing? |
| * @author Alexander Zagovorichev <zagovorichev@1pt.com> | ||
| */ | ||
|
|
||
| class PhpFileDriverTest extends PHPUnit_Framework_TestCase |
There was a problem hiding this comment.
please add a namespace to prevent collisions, and this test should work even if tao is not installed, could you consider it a unit test?
There was a problem hiding this comment.
yes, I can consider it is a unit test and this test will work even if tao is not installed. You don't like that I read real files?
|
@jbout Could you check this PR, please? |
The issue on the Windows, when
$entryis null and$entry[static::ENTRY_EXPIRATION]is not set.