Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local extended configuration #576

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

zagovorichev
Copy link
Contributor

Guide how to test:

Create config/local.conf.json file, with content:

{
  "generis": {
    "persistences": {
      "persistences": {
        "default": {
          "driver": "pdo_mysql"
        }
      }
    }
  }
}

that means that driver value will be replaced for the config generis/persistences.conf.php

return $entry;
}

private static function array_merge_recursive_ex(array $array1, array $array2)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function array_merge_recursive_ex has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Jan 29, 2019

Code Climate has analyzed commit e3c0f58 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

Copy link
Contributor

@siwane siwane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I globally approved. However, I have couple of question:

  1. if a config is overridden by an updater, do u think it can be good idea to warn devops if the target of "extendedConf.json" has been changed?
  2. Also if we want to change a ConfigurableService itself, is it possible?
  3. Last but not least, can we add a non declared config? (e.g. awsClient.conf.php)

@zagovorichev
Copy link
Contributor Author

@siwane Sorry, I've lost this PR

  1. Not sure, I guess that they have to say this. (for example, they manage cron by their own, we don't see all crons' for each user in the system on the taoUpdate).
  2. Everything possible, I've changed the driver, not a service.
  3. Yes, it will be added, I guess it was in the AC.

@siwane siwane removed their assignment Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants