-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local extended configuration #576
base: develop
Are you sure you want to change the base?
Conversation
return $entry; | ||
} | ||
|
||
private static function array_merge_recursive_ex(array $array1, array $array2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function array_merge_recursive_ex
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Code Climate has analyzed commit e3c0f58 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I globally approved. However, I have couple of question:
- if a config is overridden by an updater, do u think it can be good idea to warn devops if the target of "extendedConf.json" has been changed?
- Also if we want to change a ConfigurableService itself, is it possible?
- Last but not least, can we add a non declared config? (e.g. awsClient.conf.php)
@siwane Sorry, I've lost this PR
|
Guide how to test:
Create config/local.conf.json file, with content:
that means that
driver
value will be replaced for the configgeneris/persistences.conf.php