Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - TT-362 Symfony console implementation #582

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

martijn-tao
Copy link
Contributor

@martijn-tao martijn-tao commented Feb 4, 2019

This implements the Symfony console. PR also includes Configuration implementation using YAML, and Auto dependency resolution.

This PR works with, and depends on:

* @return array
* @throws \Exception
*/
private function resolveClassDependencies(ReflectionClass $class)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function resolveClassDependencies has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

* @param bool $rebuild
* @return array
*/
public function initialize($rebuild = false)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Feb 4, 2019

Code Climate has analyzed commit f7ecd43 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant