Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed sqlite tests #586

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fixed sqlite tests #586

wants to merge 1 commit into from

Conversation

ihar-aleksiaichuk
Copy link

changed version

@ihar-aleksiaichuk
fixed sqlite tests
e075949 
changed version
@codeclimate
Copy link

codeclimate bot commented Feb 13, 2019

Code Climate has analyzed commit e075949 and detected 0 issues on this pull request.

View more on Code Climate.

alexeyvy
alexeyvy reviewed Feb 13, 2019
View reviewed changes
test/unit/common/persistence/sql/PlatformTest.php

protected function setUp()
{
if (!extension_loaded('pdo_sqlite')) {
Copy link
Contributor

@alexeyvy alexeyvy Feb 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just use oat\generis\test\TestCase::getSqlMock() inside the test cases below. It does the same (checking the pdo_sqlite is loaded and creating connection). With this approach you don't ever need to have this setUp().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeyvy alexeyvy alexeyvy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihar-aleksiaichuk @alexeyvy