-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Doctrine Migrations STABLE #2528
Use Doctrine Migrations STABLE #2528
Conversation
|
I couldn't confirm one acceptance criteria: |
Please see scenario B taoUpdate.php output. in taoQtiTest Scenario B PR you will find two reports using the feature (use this branch for the tao-core one) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes! If you could revert the stubs to mocks which I believe I made you to do (sry dude :), PR could be accepted.
I did some changes. Let me know if we can put this in the done column. |
Goal 1: Migrate to beta1/stable and remove dependencies to @internal classes
The first goal is to replay all validation scenarios on Doctrine Migrations beta1. Most of the effort was to remove the dependency from
oat-sa/tao-core
toDoctrine\Migrations\MigrationRepository
which is an @internal class, meaning that bacwkard compatibility is not a promise...And indeed, between alpha1 and beta1, the interface got broken, so we cannot afford to extend this class so we found a little bit of a hack. Icing on the cake, the code is reduced.
Goal 2: Provide the addReport() method
As mentioned in https://oat-sa.atlassian.net/wiki/spaces/OAT/pages/380764311/1+PR+Review+Case+Study+-+New+Updater#No-More-Reports we found a regression. No more Reports allowed, as in the previous updaters. We identified this as a regression and implemented a basic support of this feature.