Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Doctrine Migrations STABLE #2528

Merged

Conversation

bugalot
Copy link
Contributor

@bugalot bugalot commented Jun 2, 2020

Goal 1: Migrate to beta1/stable and remove dependencies to @internal classes
The first goal is to replay all validation scenarios on Doctrine Migrations beta1. Most of the effort was to remove the dependency from oat-sa/tao-core to Doctrine\Migrations\MigrationRepository which is an @internal class, meaning that bacwkard compatibility is not a promise...

And indeed, between alpha1 and beta1, the interface got broken, so we cannot afford to extend this class so we found a little bit of a hack. Icing on the cake, the code is reduced.

Goal 2: Provide the addReport() method
As mentioned in https://oat-sa.atlassian.net/wiki/spaces/OAT/pages/380764311/1+PR+Review+Case+Study+-+New+Updater#No-More-Reports we found a regression. No more Reports allowed, as in the previous updaters. We identified this as a regression and implemented a basic support of this feature.

@gitromba
Copy link
Contributor

gitromba commented Jun 9, 2020

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • [] New code is respecting code style rules
  • [] New code is respecting best practices
  • [] New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • [] Changelog is updated according to changes (if applicable)
  • [] Documentation is updated according to changes (if applicable)

@gitromba
Copy link
Contributor

gitromba commented Jun 9, 2020

I couldn't confirm one acceptance criteria: A scenario in our Case Study reflects the change.

@bugalot
Copy link
Contributor Author

bugalot commented Jun 9, 2020

I couldn't confirm one acceptance criteria: A scenario in our Case Study reflects the change.

Please see scenario B taoUpdate.php output. in taoQtiTest Scenario B PR you will find two reports using the feature (use this branch for the tao-core one)

Copy link
Contributor

@gitromba gitromba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! If you could revert the stubs to mocks which I believe I made you to do (sry dude :), PR could be accepted.

@bugalot
Copy link
Contributor Author

bugalot commented Jun 9, 2020

I did some changes. Let me know if we can put this in the done column.

@bugalot bugalot changed the title Use Doctrine Migrations beta1 Use Doctrine Migrations STABLE Jun 14, 2020
@bugalot bugalot requested a review from hutnikau June 15, 2020 07:31
@bugalot bugalot merged commit 253c69f into TDR-21/migrations_tool Jun 15, 2020
@bugalot bugalot deleted the TDR-21/migrations_tool_migrations300-beta1 branch June 15, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants