Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm-bridge up to new version #2737

Merged
merged 6 commits into from
Dec 24, 2020

Conversation

alroniks
Copy link
Contributor

@alroniks alroniks commented Nov 20, 2020

Copy link
Contributor

@AndreyNegrov AndreyNegrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • The feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request's target is not master

Copy link
Contributor

@ks16 ks16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we have some dependencies which require PHP 7.4 for Composer 2 (executed on PHP 7.25, Composer 2):

Your requirements could not be resolved to an installable set of packages.
  Problem 1
    - ocramius/package-versions[1.6.0, ..., 1.9.x-dev] require php ^7.4.0 -> your php version (7.2.25) does not satisfy that requirement.
    - ocramius/package-versions[1.10.0, ..., 1.11.x-dev] require php ^7.4.7 -> your php version (7.2.25) does not satisfy that requirement.
    - ocramius/package-versions[1.3.0, ..., 1.4.2] require composer-plugin-api ^1.0.0 -> found composer-plugin-api[2.0.0] but it does not match the constraint.
    - ocramius/package-versions[1.5.0, ..., 1.5.1] require php ^7.3.0 -> your php version (7.2.25) does not satisfy that requirement.
    - oat-sa/tao-core dev-fix/CGF-22_npm_bridge_new_version requires doctrine/migrations 3.0.1 -> satisfiable by doctrine/migrations[3.0.1].
    - doctrine/migrations 3.0.1 requires ocramius/package-versions ^1.3 -> satisfiable by ocramius/package-versions[1.3.0, ..., 1.11.x-dev].
    - Root composer.json requires oat-sa/tao-core dev-fix/CGF-22_npm_bridge_new_version -> satisfiable by oat-sa/tao-core[dev-fix/CGF-22_npm_bridge_new_version].
ocramius/package-versions only provides support for Composer 2 in 1.8+, which requires PHP 7.4.

Copy link
Contributor

@bartlomiejmarszal bartlomiejmarszal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have similar error when composer update

    - ocramius/package-versions[1.6.0, ..., 1.9.x-dev] require php ^7.4.0 -> your php version (7.3.11) does not satisfy that requirement.
    - ocramius/package-versions[1.10.0, ..., 1.11.x-dev] require php ^7.4.7 -> your php version (7.3.11) does not satisfy that requirement.
    - ocramius/package-versions[1.3.0, ..., 1.5.1] require composer-plugin-api ^1.0.0 -> found composer-plugin-api[2.0.0] but it does not match the constraint.
    - oat-sa/tao-core dev-fix/CGF-22_npm_bridge_new_version requires doctrine/migrations 3.0.1 -> satisfiable by doctrine/migrations[3.0.1].
    - doctrine/migrations 3.0.1 requires ocramius/package-versions ^1.3 -> satisfiable by ocramius/package-versions[1.3.0, ..., 1.11.x-dev].
    - Root composer.json requires oat-sa/tao-core dev-fix/CGF-22_npm_bridge_new_version -> satisfiable by oat-sa/tao-core[dev-fix/CGF-22_npm_bridge_new_version].```

@alroniks
Copy link
Contributor Author

So, the problem was that author Ocramius did something that sometimes happens but it shouldn't.
The latest versions of his code require PHP 7.4 at least, that OK in an ideal world, but does not work in the business.
The composer team made the fork of his library (see readme) and recommend using that one. Also, this package comes to us from Doctrine Migrations, where people also recommend to use the suggested fork.

I've added a dependency to tao-core, which should fix issues with updating on Composer 2.0 and PHP 7.2.

@SashaTAO and @bartlomiejmarszal Could you please check again if it works?

Copy link
Contributor

@ks16 ks16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Code is self documented

@alroniks alroniks merged commit d5d798a into develop Dec 24, 2020
@alroniks alroniks deleted the fix/CGF-22_npm_bridge_new_version branch December 24, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants