fix: Set literal range for UpdatedBy resource #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbyndych
requested changes
Oct 20, 2023
There was a problem hiding this comment.
@yaraslau-kavaliou You will need a migration to sync RDFs from the file to the database. See https://github.com/oat-sa/tao-core/blob/master/migrations/Version202307101518342234_tao.php as an example.
yaraslau-kavaliou
force-pushed
the
fix/REL-1198/update-update-by-range
branch
from
d20fb49 to
6e41887
Compare
Thanks, done |
vbyndych
force-pushed
the
feat/REL-1198/list-neo4j
branch
from
b1049d1 to
05f300b
Compare
…e-update-by-range
vbyndych
approved these changes
Oct 23, 2023
Version
There are 0 BREAKING CHANGE, 1 feature, 2 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries with
UpdatedByproperty produced the wrong query to neo4j becauseUpdatedByrange was set toUsertype.E. g. - https://github.com/oat-sa/generis/blob/feat/REL-1198/list-neo4j/test/integration/model/persistence/starsql/ClassTest.php#L71
In order to fix rdf
UpdatedByrange has been set to literal.How to test:
php vendor/bin/phpunit -c phpunit.xml generis/test/integration/model/persistence/starsql/)