Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aut 3624/add translation to fe labels #4054

Conversation

marpesia
Copy link
Contributor

Related to: AUT-3624

Description:
Add new terms on a new locale language on the new SolarUi theme enabled

Changes:

  • Check Google Sheet with new terms

How to check:

php  tao/scripts/taoTranslate.php -v -a=compile -a=tao -l=en-US-S

helpers/mapLabelNameService.php Outdated Show resolved Hide resolved
helpers/mapLabelNameService.php Outdated Show resolved Hide resolved
actions/class.RdfController.php Outdated Show resolved Hide resolved
helpers/mapLabelNameService.php Outdated Show resolved Hide resolved
views/templates/blocks/sections.tpl Outdated Show resolved Hide resolved
views/templates/blocks/sections.tpl Show resolved Hide resolved
Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick code review only.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

@SultanSagi SultanSagi merged commit 77c9ee0 into feat/AUT-3675/add-support-to-SolarUI-locales Jul 16, 2024
1 check passed
@SultanSagi SultanSagi deleted the feature/AUT-3624/add-translation-to-FE-Labels branch July 16, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants