feat: advanced search support #4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsconan
approved these changes
Oct 11, 2024
gabrielfs7
reviewed
Oct 11, 2024
gabrielfs7
reviewed
Oct 11, 2024
models/classes/Translation/Listener/ResourceTranslationChangedEventListener.php
Outdated
Show resolved
Hide resolved
gabrielfs7
reviewed
Oct 11, 2024
gabrielfs7
reviewed
Oct 11, 2024
models/classes/Translation/Event/ResourceTranslationChangedEvent.php
Outdated
Show resolved
Hide resolved
…ture/adf-1794/advanced-search-support
Front-end summary Node 18
|
gabrielfs7
reviewed
Nov 13, 2024
models/classes/Translation/Listener/TranslationActionEventListener.php
Outdated
Show resolved
Hide resolved
gabrielfs7
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Thanks @shpran, amazing work!
It is working as expected and we have some minor things to address and I can approve the PR:
Issues related to adv search.
- We need to make uniqueId available as criteria
- Translation Type must not be displayed as criteria
- Translation Progress must not be displayed as criteria
- Original resource must not be displayed as criteria
… allow readonly props for search
…ture/adf-1794/advanced-search-support
shpran
commented
Nov 15, 2024
shpran
force-pushed
the
feature/adf-1794/advanced-search-support
branch
2 times, most recently
from
2b65377
to
cb01e05
Compare
shpran
force-pushed
the
feature/adf-1794/advanced-search-support
branch
from
cb01e05
to
b7fd61b
Compare
gabrielfs7
reviewed
Nov 15, 2024
gabrielfs7
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Thanks for this, @shpran. Looks great!
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
TODO
There is a small thing missing, but I am pre-approving as it is an improvement
- Do not show translation filters or columns if the translation feature flag is not enabled
- Do not show UniqueId filter o column if the feature flag is not enabled
Version
There are 0 BREAKING CHANGE, 1 feature, 0 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to:
Changes