-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new endpoint to check translation status #4134
feat: add new endpoint to check translation status #4134
Conversation
Front-end summary Node 18
|
Version
There are 0 BREAKING CHANGE, 2 features, 0 fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick code review. for the frontend part only. Looking good, nice changes!
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
- Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
LGTM 👍🏻
models/classes/Translation/Entity/ResourceTranslatableStatus.php
Outdated
Show resolved
Hide resolved
models/classes/Translation/Service/ResourceTranslatableStatusRetriever.php
Outdated
Show resolved
Hide resolved
models/classes/Translation/Service/ResourceTranslatableStatusRetriever.php
Outdated
Show resolved
Hide resolved
…t/ADF-1826/avoid-empty-translation
…o-core into feat/ADF-1826/avoid-empty-translation
https://oat-sa.atlassian.net/browse/ADF-1826
TODO
Goal
A new endpoint was introduced to get translatable status
Related PRs