Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new endpoint to check translation status #4134

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

gabrielfs7
Copy link
Contributor

@gabrielfs7 gabrielfs7 commented Nov 19, 2024

⚠️ released at #4139

https://oat-sa.atlassian.net/browse/ADF-1826

TODO

  • Rebuild FE bundle

Goal

  • Provide endpoint to check translation status
  • TBD... provide user feedback accordingly

A new endpoint was introduced to get translatable status

GET /tao/Translation/status?id=https://backoffice.ngs.test/ontologies/tao.rdf%23i673cb1b150527202411191641378f8c0526

{
    "success": true,
    "data": {
        "uri": "https://backoffice.ngs.test/ontologies/tao.rdf#i673cb1b150527202411191641378f8c0526",
        "type": "http://www.tao.lu/Ontologies/TAOTest.rdf#Test",
        "isReadyForTranslation": true,
        "isEmpty": true
    }
}

Related PRs

Screenshot 2024-11-20 at 15 14 18

Copy link

github-actions bot commented Nov 19, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
241 241 0 0

Copy link

Version

Target Version 54.24.0
Last version 54.23.2

There are 0 BREAKING CHANGE, 2 features, 0 fix

Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick code review. for the frontend part only. Looking good, nice changes!

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

Copy link
Contributor

@shpran shpran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
LGTM 👍🏻

@shpran shpran changed the base branch from develop to feat/HKD-6/integration November 22, 2024 11:11
@shpran shpran merged commit d7a81b1 into feat/HKD-6/integration Nov 22, 2024
1 check passed
@shpran shpran deleted the feat/ADF-1826/avoid-empty-translation branch November 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants