Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Translation metadata not persisted in datastore #4135

Merged

Conversation

shpran
Copy link
Contributor

@shpran shpran commented Nov 20, 2024

ADF-1828

Changes

  • Translation lists type changed from System Object to List
  • Translation lists marked as non-editable in RDF
  • Languages list marked as non-editable in RDF
  • Editable List Specification changed to check for editable property:
    • if property does not exists in the list properties - list will be editable by default
    • if property exists in the list properties - list will be editable/non-editable depending on setted value
  • Now Ld Basic Triple encoder can encode Readonly properties

Companion PRs

…eneris property, changed specification to check editable lists, allow readonly props to be encoded
Copy link

github-actions bot commented Nov 20, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
247 247 0 0

@shpran shpran force-pushed the fix/adf-1828/translation-data-in-datastore branch from fac7690 to fe69dc7 Compare November 20, 2024 09:15
Copy link

Version

Target Version 54.23.3
Last version 54.23.2

There are 0 BREAKING CHANGE, 0 feature, 1 fix

Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks!

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@shpran shpran changed the base branch from develop to feat/HKD-6/integration November 22, 2024 11:06
@shpran shpran merged commit 67c7e13 into feat/HKD-6/integration Nov 22, 2024
6 checks passed
@shpran shpran deleted the fix/adf-1828/translation-data-in-datastore branch November 22, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants