-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Translation metadata not persisted in datastore #4135
Merged
shpran
merged 5 commits into
feat/HKD-6/integration
from
fix/adf-1828/translation-data-in-datastore
Nov 22, 2024
Merged
[Fix] Translation metadata not persisted in datastore #4135
shpran
merged 5 commits into
feat/HKD-6/integration
from
fix/adf-1828/translation-data-in-datastore
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eneris property, changed specification to check editable lists, allow readonly props to be encoded
Front-end summary Node 18
|
This was referenced Nov 20, 2024
shpran
force-pushed
the
fix/adf-1828/translation-data-in-datastore
branch
from
November 20, 2024 09:15
fac7690
to
fe69dc7
Compare
gabrielfs7
reviewed
Nov 20, 2024
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
gabrielfs7
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks!
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADF-1828
Changes
Companion PRs