Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty parameters. #155

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Allow empty parameters. #155

merged 2 commits into from
Jan 20, 2021

Conversation

souphan-adsk
Copy link
Contributor

Some implementations sign the payload with empty parameters.
As a result, since the library filters out any empty parameters, it couldn't be used to generate the expected signature.

This attempts to imitate the following statement from postman:
https://www.getpostman.com/docs/v6/postman/sending_api_requests/authorization

Note: Some implementations of OAuth 1.0 require empty parameters to be added to the signature.
You can select “Add empty parameters to signature” to add empty parameters.

Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@pboling pboling merged commit b5d8055 into oauth-xx:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants