Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spec for support faraday 2 #561

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Fix spec for support faraday 2 #561

merged 1 commit into from
Feb 14, 2022

Conversation

ryogift
Copy link

@ryogift ryogift commented Jan 15, 2022

Fixed specs with reference to the upgrade guide to support Faraday 2.0.
Fixed Faraday::Builder#build cannot be used.

https://github.com/lostisland/faraday/blob/main/UPGRADING.md#others

Faraday::Builder#build method is not exposed through Faraday::Connection anymore and does not reset the handlers if called multiple times. This method should be used internally only.

Related to the following issues.
#558
https://github.com/oauth-xx/oauth2/issues/559

@pboling pboling merged commit 21f303d into oauth-xx:master Feb 14, 2022
@jrochkind
Copy link

jrochkind commented Feb 16, 2022

Hi, I'm looking at backporting to 1-4-stable, and I noted.... while the gemspec allows faraday 2.x, it may not actually be USED in CI, because of the linting dependency on danger ~> 8.4:

oauth2/Gemfile

Line 16 in 7564b81

gem 'danger', '~> 8.4'

8.4.2 is the latest release of danger, and does not allow faraday 2.0. https://rubygems.org/gems/danger/versions/8.4.2

I am confused trying to find the latest CI run here to look in logs for the bundle install output to see if faraday 2.0 is really being tested or not -- so I'm not certain.

Locally, if I manually comment out the danger dependency in Gemfile, I can update to faraday 2.2.0, and bundle exec rspec is green on master at commit da05429.

So tests are passing with faraday 2.x, but I'm not sure that CI is going to run with faraday 2.x, and it requires local changes to Gemfile to run locally with faraday 2.x and bundle exec rspec.

Filed with danger at danger/danger#1349

(And, wow, there is a serious chain of cascading dependency changes necessary to get faraday 2.x actually working).

jrochkind pushed a commit to jrochkind/oauth2 that referenced this pull request Feb 16, 2022
Co-authored-by: Ryo Takahashi <info@ryo.gift>
jrochkind pushed a commit to jrochkind/oauth2 that referenced this pull request Feb 17, 2022
Co-authored-by: Ryo Takahashi <info@ryo.gift>
jrochkind pushed a commit to jrochkind/oauth2 that referenced this pull request Feb 17, 2022
Co-authored-by: Ryo Takahashi <info@ryo.gift>
pboling pushed a commit that referenced this pull request Feb 17, 2022
#569)

* Backport: Fix spec for support faraday 2 (#561)

Co-authored-by: Ryo Takahashi <info@ryo.gift>

* Additional changes ported back from master to allow faraday 1.x and 2.x

Co-authored-by: Ryo Takahashi <takahashi@ryo.gift>
Co-authored-by: Ryo Takahashi <info@ryo.gift>
@pboling pboling added this to the 2.0.0 milestone Feb 18, 2022
@pboling pboling added the in Changelog Has been added to Changelog label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in Changelog Has been added to Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants