Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect helm template syntax in README.md #274

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

kaushall
Copy link
Contributor

@kaushall kaushall commented Jan 7, 2025

Helm uses {{ }} for its own templating, which can conflict with the Go templating syntax used in OAuth2 Proxy's templates. This change will make it working.

Helm uses `{{ }}` for its own templating, which can conflict with the Go templating syntax used in OAuth2 Proxy's templates. This change will make it working.
@pierluigilenoci
Copy link
Contributor

@kaushall, thank you for your contribution.
To proceed with the approval of the PR, we would like to ask for a few additional adjustments.

@kaushall
Copy link
Contributor Author

kaushall commented Jan 7, 2025

Thanks @pierluigilenoci, I have made the changes.

@pierluigilenoci pierluigilenoci merged commit 320ba8d into oauth2-proxy:main Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants