Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extraInitContainer option #288

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

pratiyushpushkar05
Copy link

@pratiyushpushkar05 pratiyushpushkar05 commented Feb 21, 2025

Small change .
It allows users to add initContainer of their choice in deployment .
Issue : #286

Copy link
Contributor

@pierluigilenoci pierluigilenoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is correct, but a test case needs to be added here to verify during the pipeline that the chart works with this feature.

Ref:

@pratiyushpushkar05 pratiyushpushkar05 force-pushed the add_custom_initCont branch 2 times, most recently from 45dfef3 to 1286669 Compare February 21, 2025 15:33
@tuunit tuunit force-pushed the add_custom_initCont branch from c528a0d to b0ff1ba Compare February 21, 2025 19:54
Copy link
Member

@tuunit tuunit Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I had to fix the markdown table formatting. It has been broken since the introduction of the description for option initContainers.waitForRedis.kubectlVersion

@tuunit tuunit force-pushed the add_custom_initCont branch 2 times, most recently from 6c9dca6 to 4532a71 Compare February 21, 2025 19:57
@tuunit tuunit changed the title Add extraInitContainer field Add extraInitContainer option Feb 21, 2025
@pratiyushpushkar05 pratiyushpushkar05 force-pushed the add_custom_initCont branch 2 times, most recently from c7d0fb9 to 99cbc21 Compare February 22, 2025 05:25
@tuunit
Copy link
Member

tuunit commented Feb 22, 2025

@pratiyushpushkar05 why did you revert the changes I made to the README.md?

@pratiyushpushkar05
Copy link
Author

pratiyushpushkar05 commented Feb 22, 2025

@pratiyushpushkar05 why did you revert the changes I made to the README.md?

@tuunit Must have been missed out . Didnot revert on purpose .I can see your commit on browser but not in git log locally . Sorry for inconvenience .
May be related to git force push .

@tuunit
Copy link
Member

tuunit commented Feb 22, 2025

@pratiyushpushkar05 why did you revert the changes I made to the README.md?

@tuunit Must have been missed out . Didnot revert on purpose .I can see your commit on browser but not in git log locally . Sorry for inconvenience . May be related to git force push .

I already made all the necessary changes to the PR yesterday...

@tuunit tuunit force-pushed the add_custom_initCont branch 2 times, most recently from 4532a71 to 7f0e6fa Compare February 22, 2025 18:03
tuunit
tuunit previously approved these changes Feb 22, 2025
@tuunit tuunit merged commit d1a3e1c into oauth2-proxy:main Feb 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants