-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extraInitContainer option #288
Add extraInitContainer option #288
Conversation
c6a600c
to
3814231
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is correct, but a test case needs to be added here to verify during the pipeline that the chart works with this feature.
Ref:
45dfef3
to
1286669
Compare
c528a0d
to
b0ff1ba
Compare
helm/oauth2-proxy/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but I had to fix the markdown table formatting. It has been broken since the introduction of the description for option initContainers.waitForRedis.kubectlVersion
6c9dca6
to
4532a71
Compare
c7d0fb9
to
99cbc21
Compare
@pratiyushpushkar05 why did you revert the changes I made to the README.md? |
@tuunit Must have been missed out . Didnot revert on purpose .I can see your commit on browser but not in git log locally . Sorry for inconvenience . |
I already made all the necessary changes to the PR yesterday... |
4532a71
to
7f0e6fa
Compare
7f0e6fa
to
78a6629
Compare
Small change .
It allows users to add initContainer of their choice in deployment .
Issue : #286