Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to GitHub actions #546

Closed
JoelSpeed opened this issue May 12, 2020 · 6 comments
Closed

Migrate CI to GitHub actions #546

JoelSpeed opened this issue May 12, 2020 · 6 comments

Comments

@JoelSpeed
Copy link
Member

I would like to see code coverage, linting and testing status checks for all PRs to the project. Currently with Travis, we just get the one build check. Also, because we put the code coverage ID in a travis secret, this doesn't work on PRs from forks of the repos

I think if we move to GitHub actions, we get more information from the events that trigger builds that might allow us to create conditional statements that allow our actions to run and perform code coverage only when being PR'd to the OAuth2 Proxy. What we should avoid is getting code coverage reports whenever anything is pushed to any branch of any fork.

Likewise our CodeQL action is also broken and only works for pushes to this repository and not forks. It would be good to fix that too.

@shinebayar-g
Copy link
Contributor

I can migrate your travis configuration to github actions if you want

@JoelSpeed
Copy link
Member Author

If you have experience with actions, that would be appreciated

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed.

@github-actions github-actions bot added the Stale label Aug 22, 2020
@JoelSpeed JoelSpeed removed the Stale label Aug 23, 2020
@JoelSpeed
Copy link
Member Author

I would still like to see this done

@shinebayar-g
Copy link
Contributor

Opened PR

@JoelSpeed
Copy link
Member Author

Just had a look at the PR, looks like a great start, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants