-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate to Github Actions, close #546 #750
ci: migrate to Github Actions, close #546 #750
Conversation
This is more of a bash problem at the moment. Looks like we need to install golangci-lint into some other directory, I wonder if we can do that easily using the existing go releaser scripts On a separate note, if we do this migration, I'd like to keep travis and github actions on initially, so that we can compare the results and make sure there are no issues with the new CI. Can we drop the travis ci drop from this PR please? I think it might be good to use this opportunity to create three status checks, one for linting, one for the tests and one for build, ie, does the code compile, this may require some changes to the Makefile targets but shouldn't be too much. I think we basically want to get the output of |
@NickMeves @syscll @gargath WDYT of this suggestion? |
15921b9
to
5cd2e0e
Compare
@JoelSpeed I've figured most of the workflow. Now I'm not sure what to do with ./after build script. |
This needs to be in the test step, so I'd prefer if we had three separate jobs, which would give us three separate ticks right? For the test one ( |
…proxy into migrate-to-actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gonna wait for checks to pass, then ready to merge!
Thanks @shinebayar-g
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Description
Let's migrate to Github Actions
Motivation and Context
See: #546 for more details
How Has This Been Tested?
I'm not Go developer, so I need your guidance to complete it.
yml
file syntax is pretty similar to travis ci. So I hope you'll be able to easily see what's going on.Right now build is broken. Because of I don't know what's needed to fix. See builds here: https://github.com/shinebayar-g/oauth2-proxy/actions
Once we figure out travis ci replacement, we can move onto codeql action.
Checklist: