Update to Go 1.16 #1054
Merged
Update to Go 1.16 #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickMeves
previously approved these changes
Feb 18, 2021
This includes a fix for our samesite cookie parsing. The behaviour changed in 1.16 so that the default value now leaves it empty, so it's equivalent to not setting it (as per spec)
This allows our users to easily copy the base templates should they wish to make changes to them
|
I updated the changelog, no other changes since approval |
10 tasks
Jing-ze
pushed a commit
to Jing-ze/oauth2-proxy
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Go to 1.16.
Use the embed package to extract default page templates into html files.
Motivation and Context
This will make it easier for people to use our existing templates as bases for their own templates if they decide to customise the look of OAuth2 Proxy.
Since Go 1.16 has literally only just been release, this may be a bit premature? Not sure
How Has This Been Tested?
Manually using the local testing environment + unit tests cover this.
Checklist: