redirect to original path after login

[agentgonzo]

Description

After the user logs in, redirect them to their original URL rather than just /

Motivation and Context

The user wants to go to their destination, no the root URL.

How Has This Been Tested?

Run it against an upstream. Trash all cookies, then try to access it with a non-root URL

Checklist:

• My change requires a change to the documentation or CHANGELOG.
• I have updated the documentation/CHANGELOG accordingly.
• I have created a feature (non-master) branch for my PR.

[JoelSpeed]

I like the idea behind this PR, but at the moment it would break people using the auth_request directive as described in the documentation.

If I'm using the auth_request directive then Nginx redirects users to /oauth2/sign_in to perform the login and this means req.URL.Path would be /oauth2/sign_in which would mean people would get into a loop of being asked to sign in. We need to work out a way to stop that happening before we can add this enhancement. Any ideas?

[agentgonzo]

pseudocode:

if originalrequest.startswith('/oauth)
    redirect = '/'
else
    redirect = originalPath

?

[JoelSpeed]

I've just realised that's what

if strings.HasPrefix(redirect, p.ProxyPrefix) {
			redirect = "/"
}

is for... Ignore my previous comment

[JoelSpeed]

Could you possibly add a test for the GetRedirect method that tests a couple of cases (in particular a random original path and then also one which contains the p.ProxyPrefix) please?

[agentgonzo]

Will do. Probably to come on Monday

[agentgonzo]

@JoelSpeed - tests added. Let me know if you need anything else

[JoelSpeed]

One minor nit then it's good to go! Thanks

[JoelSpeed]

This comment isn't quite right

Suggested change

	name: "request under of ProxyPrefix redirects to original URL",
	name: "request under ProxyPrefix redirects to root",

[agentgonzo]

fixed

[JoelSpeed]

Could you add a note to the Changelog noting this bug fix?