Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version check for bash version gteq 4 #292

Merged
merged 6 commits into from
Oct 28, 2019

Conversation

jmfrank63
Copy link
Contributor

@jmfrank63 jmfrank63 commented Oct 21, 2019

Description

Fixes #291

Motivation and Context

How Has This Been Tested?

I ran configure against bash version <4. The script fails with the reported error.

I then upgraded to bash version 5 via homebrew.

As a result the script ran fine.

I uninstalled bash again falling back to the native OSX version.

I ran configure again resulting in:
This script requires Bash version >= 4

After reinstalling bash via homebrew again the script did work again.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

I am not yet fully confident of the style on a CHANGELOG entry. I am willing to do the change but would like some guidance.

JoelSpeed
JoelSpeed previously approved these changes Oct 21, 2019
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't directly tested this but had a play with ${BASH_VERSINFO} in my shell (didn't know it was a thing!) and it looks like this should work well, thanks for the fix @jmfrank63

I think adding a note to the changelog would be good if you have a moment to do so?

loshz
loshz previously approved these changes Oct 21, 2019
Copy link
Member

@loshz loshz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Please add an entry to the changelog and I'll get this merged.

@jmfrank63 jmfrank63 dismissed stale reviews from loshz and JoelSpeed via 2f37479 October 27, 2019 13:32
CHANGELOG.md Outdated
@@ -232,3 +232,4 @@ v2.2 as released by Bitly.
- Repository forked on 27/11/18
- README updated to include note that this repository is forked
- CHANGLOG created to track changes to repository from original fork
- Added bash >= 4.0 dependency to configure script
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this should be of the format:

- [#292](https://github.com/pusher/oauth2_proxy/pull/292) Added bash >= 4.0 dependency to configure script (@jmfrank63)

And should be at the top of this file with the more recent changes (changes since v4.0.0)

Copy link
Member

@loshz loshz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congrats on your first contribution! 🎉

@loshz loshz merged commit 292d2dc into oauth2-proxy:master Oct 28, 2019
Jing-ze pushed a commit to Jing-ze/oauth2-proxy that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure script broken for bash versions < 4
3 participants