Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store inputs, as @ericwastl asked #57

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Conversation

obalunenko
Copy link
Owner

  • Don't store inputs
  • Move command to internal
  • Regression test

@obalunenko obalunenko changed the title Refactor inputs Don't store inputs, as @ericwastl asked Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #57 (e92cf28) into master (c1068f6) will increase coverage by 9.44%.
The diff coverage is 2.32%.

❗ Current head e92cf28 differs from pull request most recent head 9714abd. Consider uploading reports for the commit 9714abd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   66.99%   76.44%   +9.44%     
==========================================
  Files          26       23       -3     
  Lines        1624     1405     -219     
==========================================
- Hits         1088     1074      -14     
+ Misses        443      241     -202     
+ Partials       93       90       -3     
Impacted Files Coverage Δ
internal/command/command.go 0.00% <0.00%> (ø)
internal/command/context.go 0.00% <0.00%> (ø)
internal/puzzles/day_string.go 100.00% <ø> (ø)
internal/puzzles/solver.go 60.36% <100.00%> (ø)
cmd/aoc-cli/flags.go
cmd/aoc-cli/handlers.go
cmd/aoc-cli/commands.go
cmd/aoc-cli/version.go
cmd/aoc-cli/main.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1068f6...9714abd. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@obalunenko obalunenko merged commit fda8e78 into master Dec 1, 2021
@obalunenko obalunenko deleted the refactor-inputs branch December 1, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant