Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to generics usage #53

Merged
merged 11 commits into from
Jan 30, 2023
Merged

Conversation

obalunenko
Copy link
Owner

@obalunenko obalunenko commented Jan 29, 2023

Description

Migrated code to usage of generics.

  • Implemented EnvOrDefault generic function
  • Add support of new types for env variables: []int, []int64, float64 | []float64

Issue

#52

Possible failures/side-effects

Possible staticcheck linter warnings on usage of deprecated functions.

Other notes

none

@obalunenko obalunenko linked an issue Jan 29, 2023 that may be closed by this pull request
@obalunenko obalunenko self-assigned this Jan 29, 2023
@obalunenko obalunenko marked this pull request as ready for review January 29, 2023 23:27
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 93.93% // Head: 100.00% // Increases project coverage by +6.06% 🎉

Coverage data is based on head (eddfd4c) compared to base (2d19c8e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master       #53      +/-   ##
===========================================
+ Coverage   93.93%   100.00%   +6.06%     
===========================================
  Files           1         1              
  Lines          66        32      -34     
===========================================
- Hits           62        32      -30     
+ Misses          2         0       -2     
+ Partials        2         0       -2     
Impacted Files Coverage Δ
getenv.go 100.00% <100.00%> (+6.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

15.6% 15.6% Coverage
0.0% 0.0% Duplication

@obalunenko obalunenko merged commit 8b67b00 into master Jan 30, 2023
@obalunenko obalunenko deleted the 52-migrate-to-generics-usage branch January 30, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to generics usage.
1 participant