Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serial number to CertificateIssued log struct #52

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Add serial number to CertificateIssued log struct #52

merged 5 commits into from
Jun 6, 2024

Conversation

harry-anderson
Copy link
Collaborator

@harry-anderson harry-anderson commented Jun 4, 2024 •
edited
Loading

  • Add serial member to CertificatedIssued struct.
  • Log serial when Certificate is issued.
  • Add serial tag to infux logger

@harry-anderson harry-anderson marked this pull request as ready for review June 4, 2024 05:03
@obelisk
Copy link
Owner

obelisk commented Jun 6, 2024

Please add a PR description :)

obelisk
obelisk requested changes Jun 6, 2024
View reviewed changes
Copy link
Owner

@obelisk obelisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a new serial tag to the influx logger.

rustica/src/logging/mod.rs Outdated Show resolved Hide resolved
@harry-anderson harry-anderson requested a review from obelisk June 6, 2024 05:27
@obelisk obelisk merged commit dbbf7f7 into obelisk:develop Jun 6, 2024
8 checks passed
@harry-anderson harry-anderson deleted the harry/feat/add_serial_number branch June 6, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obelisk obelisk obelisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harry-anderson @obelisk