This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
use metric alias to find metrics instead of relying on target attribute #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes graphite changes the target attribute it returns, so tasseo should not rely on it to find the data points.
This PR makes tasseo use the alias, which I think it is cleaner.
For example, if you try to use the following tasseo.metric.target:
Graphite will return something like (notice the quotes):
So it won't work, because tasseo can't find this metric in the response using the target it sent.
With this PR, graphite will always return
target: <alias>
so we can usemetric.alias
to find the data points inmetricResults
.