-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retransmit is a protocol detail and should not be implemented in the client #8
Comments
Your observation is correct. This is some artifact that needs
cleanup. Before proceeding with this, please note that there are change
proposals to move the network I/O callbacks into the endpoint structure
and to factor out platform-specific code:
https://sourceforge.net/p/libcoap/mailman/libcoap-developers/thread/559A02B3.7060109%40netcommwireless.com/#msg34268958
https://sourceforge.net/p/libcoap/mailman/libcoap-developers/thread/1434009375.4418.11.camel%40sastrion.pl/#msg34196444
|
This has been resolved in the meantime by the |
mrdeep1
added a commit
to mrdeep1/libcoap
that referenced
this issue
Dec 9, 2022
Small adjustment so vim isn't complaining about wrong modlines any more.
mrdeep1
added a commit
to mrdeep1/libcoap
that referenced
this issue
Dec 13, 2022
Small adjustment so vim isn't complaining about wrong modlines any more.
mrdeep1
added a commit
to mrdeep1/libcoap
that referenced
this issue
Dec 17, 2022
Small adjustment so vim isn't complaining about wrong modlines any more.
mrdeep1
added a commit
to mrdeep1/libcoap
that referenced
this issue
Dec 20, 2022
Small adjustment so vim isn't complaining about wrong modlines any more.
mrdeep1
added a commit
to mrdeep1/libcoap
that referenced
this issue
Dec 30, 2022
Small adjustment so vim isn't complaining about wrong modlines any more.
mrdeep1
added a commit
to mrdeep1/libcoap
that referenced
this issue
Jan 2, 2023
Small adjustment so vim isn't complaining about wrong modlines any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All of the POSIX examples implement the re-transmit part of the standard in the application code, mostly to make up for the fact that it isn't implemented in the library itself.
E.g. in examples/client.c:
This is unsanitary and breaks many of the abstractions in obvious ways. For example, the coap_context_t object when compiled with -DWITH_POSIX keeps a reference to the socket so that - and this is the only reason as far as I can tell - the client can use it in its re-transmit code.
The Contiki & lwIP ports implement re-transmit in the library, which makes the above fact even more puzzling.
The text was updated successfully, but these errors were encountered: