Fix handling ICMP Port Unreachable messages #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once a ICMP Port Unreachable message is received, the session is disconnected by a call to coap_session_disconnect(). However if the session is of type CON, the logic currently tries to retransmit the packet, but nothing gets sent out. src/coap_session.c: Make sure that any entries on the context->sendqueue for the disconnected session are removed. examples/client.c: Add in a Nack handler so that the client immediately exits on the session disconnect. Additionally this also tidies up the exit after transmission retries.
|
It's into RST case in NACK handler on both scenarios:
Thanks! |
|
I need to think this through. Differentiating between the 2 makes some sense and have some code now that does just that. However, I was reminded of #131 where ICMP diagnostic messages can be transient and so UDP should be retrying where appropriate, including restarting DTLS if appropriate. I have not got the DTLS part working yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once a ICMP Port Unreachable message is received, the session is
disconnected by a call to coap_session_disconnect(). However if the session
is of type CON, the logic currently tries to retransmit the packet, but
nothing gets sent out.
src/coap_session.c:
Make sure that any entries on the context->sendqueue for the disconnected
session are removed.
examples/client.c:
Add in a Nack handler so that the client immediately exits on the session
disconnect. Additionally this also tidies up the exit after transmission
retries.
Fixes the issue picked up by #347