Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make language tags consistent #1793

Closed
cmungall opened this issue Jun 18, 2024 · 4 comments · Fixed by #1795
Closed

Make language tags consistent #1793

cmungall opened this issue Jun 18, 2024 · 4 comments · Fixed by #1795

Comments

@cmungall
Copy link
Contributor

Half the OBI definitions have lang=en, the others are plain literals/strings

➜  ontology git:(master) ✗ grep IAO_0000115 obi-edit.owl | grep -c lang=
656
➜  ontology git:(master) ✗ grep IAO_0000115 obi-edit.owl | grep -vc lang=
702

I don't think there is OBO guidance but I think intra-ontology consistency is always good, it seems your intent is to be explicit, I think it would be clearly safe to auto-convert all definitions to lang=en

@turbomam
Copy link
Contributor

turbomam commented Jun 24, 2024

Background from @jamesaoverton

  • there used to be a plain RDF literal but now there are only language-tagged literals and datatype-tagged literals. A literal that has no explicit language or datatype tag is implicitly an xsd:string typed datatype literal
  • adding a tag in Protege takes extra clicks so a lot of people don't do it
  • Some ontologies may appear to have duplicate textual assertions like definitions or labels, but that can because the object appears in multiple language or datatype tagged format. Sometimes this can be attributed to the object having different tags in different imports. OWL considers "shark"@en and "shark"^^xsd:string different value.

@turbomam
Copy link
Contributor

turbomam commented Jun 24, 2024

@cmungall is explicitly calling out definitions, but this is equally applicable to the objects of other triples (like rdfs:label). There's some acknowledgement of that in the PR discussion.

This work will need to be applied to inputs other than obi-edit.owl, like ROBOT templates. The bare use of AL column headers (without specifying the language code like @en) isn't a complete solution.

@turbomam
Copy link
Contributor

turbomam commented Jun 24, 2024

Attendees in today's meeting agree with the content of this PR and appreciate the clever implementation. The way Dragon AI modified the tab characters make break the expectations of the ROBOT template format.

I and or @sebastianduesing will build upon it.

@turbomam
Copy link
Contributor

turbomam commented Jun 24, 2024

we'll finish this PR on definitions and start another one for labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants