Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom target directory causes generated rustdoc files to overwrite each other #269

Closed
tonowak opened this issue Jan 6, 2023 · 0 comments · Fixed by #270
Closed

Custom target directory causes generated rustdoc files to overwrite each other #269

tonowak opened this issue Jan 6, 2023 · 0 comments · Fixed by #270
Assignees
Labels
C-bug Category: doesn't meet expectations

Comments

@tonowak
Copy link
Collaborator

tonowak commented Jan 6, 2023

Steps to reproduce the bug with the above code

cd /tmp
git clone ssh://git@github.com:obi1kenobi/cargo-semver-checks
cd cargo-semver-checks
mkdir -p .cargo
echo '[build]\ntarget-dir = "/tmp/target"' > .cargo/config.toml
cargo run semver-checks check-release --manifest-path ./test_crates/enum_missing/new/Cargo.toml --baseline-root=./test_crates/enum_missing/old/Cargo.toml

Actual Behaviour

It ends successfully without reporting any issues.

Expected Behaviour

It should find a semver breaking issue.

Generated System Information

Software version

cargo-semver-checks 0.15.2 (f6b41f4)

Operating system

Linux 6.1.1-arch1-1

Command-line

/tmp/target/debug/cargo-semver-checks semver-checks --bugreport

cargo version

> cargo -V
cargo 1.67.0-beta.2 (f6e737b1e 2022-12-02)

Compile time information

  • Profile: debug
  • Target triple: x86_64-unknown-linux-gnu
  • Family: unix
  • OS: linux
  • Architecture: x86_64
  • Pointer width: 64
  • Endian: little
  • CPU features: fxsr,sse,sse2
  • Host: x86_64-unknown-linux-gnu

Additional Context

I think this bug happens when the binary is in any other place other than in the default path (not only by passing a custom path to the built binary).

@tonowak tonowak added the C-bug Category: doesn't meet expectations label Jan 6, 2023
obi1kenobi added a commit that referenced this issue Jan 8, 2023
@obi1kenobi obi1kenobi changed the title Doesn't find any issues when the binary is ran from another directory Custom target directory causes generated rustdoc files to overwrite each other Jan 9, 2023
obi1kenobi added a commit that referenced this issue Jan 9, 2023
* Add a field to the bug report form for config.toml information.

This would have made #269 easier to find.

* Update bug_report.yml
@tonowak tonowak self-assigned this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: doesn't meet expectations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants