Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lints: Enum tuple variant field removed/added #259

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

staniewzki
Copy link
Collaborator

@obi1kenobi
Copy link
Owner

All the dependent changes have been merged, so this should be unblocked as soon as you resolve the merge conflict.

@staniewzki staniewzki force-pushed the tuple-variant-field-removed branch from 3613fc0 to 70a341e Compare March 15, 2023 16:16
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
@staniewzki staniewzki force-pushed the tuple-variant-field-removed branch from 7505c2f to 5867f93 Compare March 15, 2023 17:06
@staniewzki staniewzki marked this pull request as ready for review March 15, 2023 17:26
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will merge with a couple of minor phrasing tweaks.

src/lints/enum_tuple_variant_field_added.ron Outdated Show resolved Hide resolved
src/lints/enum_tuple_variant_field_missing.ron Outdated Show resolved Hide resolved
src/lints/enum_tuple_variant_field_missing.ron Outdated Show resolved Hide resolved
src/lints/enum_tuple_variant_field_missing.ron Outdated Show resolved Hide resolved
@obi1kenobi obi1kenobi enabled auto-merge (squash) March 22, 2023 22:01
@obi1kenobi obi1kenobi merged commit 07b8f38 into obi1kenobi:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose enum variant fields on interface Variant
2 participants