Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rustdoc .json files overwriting each other #270

Merged
merged 17 commits into from
Jan 23, 2023
Merged

Fix rustdoc .json files overwriting each other #270

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
992e677
Load rustdoc immediately into memory
staniewzki Jan 7, 2023
137eb90
Running the lints immediately after creating the rustdocs
tonowak Jan 8, 2023
53cb4fa
fmt
tonowak Jan 8, 2023
f18dfec
Update src/main.rs
tonowak Jan 9, 2023
f0038a4
Review adjustments
tonowak Jan 9, 2023
4dd7852
Extract rustdoc generation
staniewzki Jan 21, 2023
e94540d
Minor adjustments
staniewzki Jan 21, 2023
950ed3b
Add clap run to CI
staniewzki Jan 22, 2023
a866487
Edit CI
staniewzki Jan 22, 2023
62e224c
Undo typo
staniewzki Jan 22, 2023
314a2da
replace ! with not
staniewzki Jan 22, 2023
4107c67
Try another way to negate
staniewzki Jan 22, 2023
1e91d52
CI fix attempt #3
tonowak Jan 22, 2023
57f3950
Adjust comments
staniewzki Jan 23, 2023
3260424
Remove redundant check
staniewzki Jan 23, 2023
7f7fa16
Require the new job to succeed before CI passes
obi1kenobi Jan 23, 2023
f98e64e
Quote shell expansions in GitHub Action
obi1kenobi Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,12 +292,12 @@ jobs:

- name: Check return code
run: |
if [[ $(cat return_code) == 0 ]]; then exit 1; else exit 0; fi
if [[ "$(cat return_code)" == "0" ]]; then exit 1; else exit 0; fi

- name: Check output
run: |
EXPECTED=$(echo -e "--- failure auto_trait_impl_removed: auto trait no longer implemented ---\n--- failure trait_missing: pub trait removed or renamed ---")
RESULT=$(cat output | grep failure)
EXPECTED="$(echo -e "--- failure auto_trait_impl_removed: auto trait no longer implemented ---\n--- failure trait_missing: pub trait removed or renamed ---")"
tonowak marked this conversation as resolved.
Show resolved Hide resolved
RESULT="$(cat output | grep failure)"
diff <(echo "$RESULT") <(echo "$EXPECTED")

init-release:
Expand Down