bump cargo-toml to 0.15.2 and remove workarounds

[skyzh]

Thanks to @kornelski for a quick review for my PR to cargo_toml and we can remove the workaround now!

[obi1kenobi]

Thanks for opening a PR for the fix!

[skyzh]

Comment resolved! Actually we can use anyhow's .context here, which produces something like (as in anyhow::Context example):

Error: Failed to read instrs from ./path/to/instrs.json

Caused by:
    No such file or directory (os error 2)

        let parsed = cargo_toml::Manifest::from_path(&path)
            .with_context(|e| format!("Failed when reading {}", path.display())?;

Do you feel this is a better way to throw an error? If so I can refactor map_err to context for manifest errors in this PR.

[obi1kenobi]

Yes, definitely! Thanks!

…

On Sat, Feb 18, 2023, 2:28 PM Alex Chi ***@***.***> wrote: Comment resolved! Actually we can use anyhow's .context here, which produces something like (as in anyhow::Context <https://docs.rs/anyhow/latest/anyhow/trait.Context.html> example): Error: Failed to read instrs from ./path/to/instrs.json Caused by: No such file or directory (os error 2) let parsed = cargo_toml::Manifest::from_path(&path) .with_context(|e| format!("Failed when reading {}", path.display())?; Do you feel this is a better way to throw an error? If so I can refactor map_err to context for manifest errors in this PR. — Reply to this email directly, view it on GitHub <#374 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5MSSV5HWTH6MILONGV53WYEPGVANCNFSM6AAAAAAVAA3X7Y> . You are receiving this because you commented.Message ID: ***@***.***>

[skyzh]

done :)

[obi1kenobi]

Awesome! Thank you so much!