Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error reporting when manifests fail to parse. #379

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

obi1kenobi
Copy link
Owner

@obi1kenobi obi1kenobi commented Feb 21, 2023

Improved error message for cases like #376. I'm under no illusions that this new UX is perfect, but it's certainly better than before and we can keep making it better still.

Before:

$ cargo semver-checks check-release --manifest-path common/config/Cargo.toml 
     Parsing bootloader-boot-config v0.11.0 (current)
Error: package `bootloader-boot-config` not found in common/config

After:

$ cargo semver-checks check-release --manifest-path common/config/Cargo.toml 
     Parsing bootloader-boot-config v0.11.0 (current)
Error: package `bootloader-boot-config` not found in common/config

Caused by:
    possibly due to errors: [
      failed when reading common/config/Cargo.toml: not all fields of `bootloader-boot-config` have been present in workspace.package,
    ]

@obi1kenobi obi1kenobi enabled auto-merge (squash) February 21, 2023 19:00
@obi1kenobi obi1kenobi merged commit 17d33d7 into main Feb 21, 2023
@obi1kenobi obi1kenobi deleted the better_error_reporting branch February 21, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant